GLTFLoader: Revert usage of computeTangents(). #21186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
approved these changes
Feb 1, 2021
Collaborator
donmccurdy
left a comment
donmccurdy
left a comment
There was a problem hiding this comment.
Thanks!
I'm looking into the original issue a bit more now.
Owner
|
Thanks! |
Collaborator
Calling When tangents are computed by the loader, this code block is executed, which flips /ping @elalish |
Collaborator
|
I've added an option generating MikkTSpace vertex tangents for any glTF file with an offline CLI here: https://gltf-transform.donmccurdy.com/cli.html ... for example: It works on the web too (using WebAssembly) but MikkTSpace requires unwelding mesh vertices, so — similar to this PR — it's probably not something that we'd want to automatically apply to all glTF files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #11438 (comment)
Description
It seems computing tangents currently breaks NormalTangentTest test asset. Reverting the change solves the issue for now.
I guess we have to find another way to fix double sided rendered models.