Skip to content

Conversation

@donmccurdy
Copy link
Collaborator

@donmccurdy donmccurdy commented Jan 23, 2021

Provides a parseInternalAsync method that KTX2Loader can begin using in a future PR, so that the transcoding logic can be mostly shared between the two loaders. This will allow us to remove the msc_basis_transcoder files and have only a single Basis transcoder in the project. The change also improves selection of the target format into which Basis textures are transcoded.

Tested on:

  • ✅ iPhone 11, Safari
  • ✅ iPhone SE, Safari
  • ✅ iPad, Safari
  • ✅ macOS (Safari, Firefox, Chrome)
  • ✅ Pixel 4 (Chrome, Firefox)
  • ✅ Nexus 5X (Chrome)

Some parts of this change require using the latest version of the Basis transcoder, checked in with #21094. This should be noted as a "breaking change" in the release notes, since users may have copied the old transcoder files into a local directory and would need to update them now.

@mrdoob mrdoob added this to the r125 milestone Jan 23, 2021
@donmccurdy donmccurdy mentioned this pull request Jan 23, 2021
12 tasks
@mrdoob mrdoob merged commit f4f930c into mrdoob:dev Jan 23, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jan 23, 2021

Thanks!

@donmccurdy donmccurdy deleted the feat-basistextureloader-reuse branch January 24, 2021 02:58
@donmccurdy
Copy link
Collaborator Author

@Mugen87, I'm having trouble updating running modularize.js on the dev branch (see #21138) and can't address your comments at the moment.

@mrdoob
Copy link
Owner

mrdoob commented Jan 25, 2021

Should be working again #21138 (comment)

@donmccurdy
Copy link
Collaborator Author

/cc #21144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants