Fix getting float render target extensions #21069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Different extensions may be required to enable rendering to floating point textures depending on WebGL version and implementation.
EXT_color_buffer_half_float may be supported on WebGL 2 on platforms that support 16-bit float render targets but not 32-bit float render targets.
|
Thanks! |
Mugen87
reviewed
Jan 12, 2021
|
I always get this warning now:
Is that expected? |
|
Yes, I think Chrome warns whenever an unsupported extension is requested. We could potentially use getSupportedExtensions to query extensions before calling getExtension to silence these warnings, if that's desired. |
This was referenced Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebGLRenderer now requests all the different floating point render target extensions from the GL context. On WebGL 2, float render targets are enabled by EXT_color_buffer_float, and EXT_color_buffer_half_float may provide half float render target support on both WebGL 1 and WebGL 2.
This contribution is funded by Higharc.