Skip to content

Examples: Refactor webgl_simple_gi. #20996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2021
Merged

Examples: Refactor webgl_simple_gi. #20996

merged 1 commit into from
Jan 4, 2021

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jan 4, 2021 •
edited
Loading

Related issue: -

Description

Monkey-patching THREE.Mesh.prototype.clone like in the example was considered as a hack. It seems more robust to just derive a custom class GIMesh and overwrite the implementation.

Because of #19471, we should not modify clone() anymore but copy().

@mrdoob mrdoob added this to the r125 milestone Jan 4, 2021
@mrdoob mrdoob merged commit 4d5b5d0 into mrdoob:dev Jan 4, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jan 4, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r125

Development

Successfully merging this pull request may close these issues.

2 participants

@Mugen87 @mrdoob