Skip to content

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Dec 29, 2020

Related issue: see #20941 (comment)

Description

This PR replaces the usage of inflate.js with fflate.js in FBXLoader, VTKLoader and EXRLoader.

/cc @sciecode, @looeee

Copy link

@101arrowz 101arrowz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly to assure users that Three.js is fully FOSS, it might be useful to add doc comments to the minified files for fflate:

fflate.js:

/*!
fflate - fast JavaScript compression/decompression
<https://101arrowz.github.io/fflate>
Licensed under MIT. https://github.com/101arrowz/fflate/blob/master/LICENSE
Subset included: synchronous unzip, gunzip, and unzlib
*/

fflate-deflate.js (if this is added down the line):

/*!
fflate - fast JavaScript compression/decompression
<https://101arrowz.github.io/fflate>
Licensed under MIT. https://github.com/101arrowz/fflate/blob/master/LICENSE
Subset included: synchronous deflate
*/

@sciecode
Copy link
Contributor

Tested all internal EXRLoader usages of fflate.js, everything looks in order.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Dec 29, 2020

Mainly to assure users that Three.js is fully FOSS, it might be useful to add doc comments to the minified files for fflate:

Done for fflate.min.js and fflate.module.min.js. fflate-deflate is not yet part of the repo.

@mrdoob mrdoob added this to the r125 milestone Dec 29, 2020
@mrdoob mrdoob merged commit 9da45f5 into mrdoob:dev Dec 30, 2020
@mrdoob
Copy link
Owner

mrdoob commented Dec 30, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants