Skip to content

Conversation

@Tonvey
Copy link
Contributor

@Tonvey Tonvey commented Dec 25, 2020

Hi,
I change the cloneable class typescript declaration.
In some cases , I need to write a class inherit from those cloneable class
and override the member function "clone" . It will raise a typescript compile error because
of the super class return type. In fact , the clone function return a new instance , not the instance "this"

@mrdoob mrdoob added this to the r125 milestone Dec 26, 2020
@mrdoob mrdoob merged commit 579d0e3 into mrdoob:dev Dec 26, 2020
@mrdoob
Copy link
Owner

mrdoob commented Dec 26, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants