Skip to content

Fix type declaration of Vector4 #20927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2020
Merged

Fix type declaration of Vector4 #20927

merged 1 commit into from
Dec 22, 2020

Conversation

@hujiulong
Copy link
Contributor

Description

The parameter type of setAxisAngleFromRotationMatrix should be Matrix4.

Refer to the doc:

three.js/docs/api/en/math/Vector4.html

Line 266 in 821df03

<h3>[method:this setAxisAngleFromRotationMatrix]( [param:Matrix4 m] )</h3>

@Mugen87 Mugen87 added this to the r124 milestone Dec 22, 2020
@mrdoob mrdoob merged commit 8074a7d into mrdoob:dev Dec 22, 2020
@mrdoob
Copy link
Owner

mrdoob commented Dec 22, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r124

Development

Successfully merging this pull request may close these issues.

3 participants

@hujiulong @mrdoob @Mugen87