Skip to content

Extract light from control into light section #20923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 21, 2020
Merged

Extract light from control into light section #20923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77bec12
Update Layers.html
CreaticDD Dec 5, 2020
38bf5f4
Merge pull request #20832 from donutcoffee/patch-1
mrdoob Dec 21, 2020
1a6d8e3
Extract light from control into light section
Ph0tonic Dec 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/api/en/core/Layers.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ <h3>[method:Boolean test]( [param:Layers layers] )</h3>
<p>
layers - a Layers object<br /><br />

Returns true if this and the passed *layers* object are members of the same set of layers.
Returns true if this and the passed *layers* object have at least one layer in common.
</p>

<h3>[method:null toggle]( [param:Integer layer] )</h3>
Expand Down
10 changes: 6 additions & 4 deletions examples/webgl_geometry_convex.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,13 @@
controls.minDistance = 20;
controls.maxDistance = 50;
controls.maxPolarAngle = Math.PI / 2;


// ambient light

scene.add( new THREE.AmbientLight( 0x222222 ) );

// light

// point light
const light = new THREE.PointLight( 0xffffff, 1 );
camera.add( light );

Expand Down