Skip to content

Conversation

@1993heqiang
Copy link
Contributor

Description

remove redundant brackets

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 20, 2020

At most of these place, the additional brackets improve readability. TBH, I do not vote to remove them.

@1993heqiang
Copy link
Contributor Author

At most of these place, the additional brackets improve readability. TBH, I do not vote to remove them.

I don't think these brackets can improve readability. At least this is not:
image

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 20, 2020

Yeah, this one and the changes in Raycaster are an exception.

@1993heqiang
Copy link
Contributor Author

Yeah, this one and the changes in Raycaster are an exception.

I agree with your opinion. I have resubmitted a new PR and only modify Object3D
.js and Raycaster.js.#20916

@1993heqiang 1993heqiang deleted the format_optimization branch December 20, 2020 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants