EdgeSplitModifier - Keep normals #20903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As of right now, when using this modifier, you lose all the normals of the geometry you used as input. This is due to the fact that splitting invalidates the previous normals. Right now, you need to recompute the normals using
computeVertexNormals().However, not all normals should be invalidated, and you might want to try and keep their previous values as much as possible, especially if they don't correspond to their computed counterparts.
This PR adds a new parameter to
EdgeSplitModifier.modifynamedtryKeepNormals. When it is set to true, and you provided an indexed geometry with normals, it will keep the normals values for vertices that weren't split by the modifier.First image is with computed vertices (
tryKeepNormals = false), second one hastryKeepNormalsset totrue:Note
This PR is a branch of #20855
This contribution is funded by Dualbox.