GLTFLoader: Use sanitized name when creating unique node name for duplicated name #20880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrdoob
changed the title
|
Thanks! |
|
Hello! The gltf model sets a component to be transparent, but the component set after the model is loaded is not transparent, I found that the transparent property of material is false. |
|
@John-D-a-i Hi! We use GitHub issues to track confirmed bug reports and feature development. If you need help, please use the forum or stackoverflow. |
Mercury21th000
added a commit
to Mercury21th000/gltfjsx
that referenced
this pull request
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #20843
Description
Issue: Duplicated node names are correctly appended with
_ifor use in the three.js animation system, however when assigning the name of these specifically, the unsanitized string is used.Solve: Assign a new variable called
sanitizedNameso that it can be used over and over again in the for loop which loops over and appends_ito duplicated node names.