src: ES6 default value. #20840
Merged
src: ES6 default value. #20840
+19
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
reviewed
Dec 5, 2020
| const _sphere = new Sphere(); | ||
|
|
||
| function Line( geometry, material, mode ) { | ||
| function Line( geometry = new BufferGeometry(), material = new LineBasicMaterial(), mode ) { |
There was a problem hiding this comment.
I think it's okay to finally remove the mode parameter.
@mrdoob What do you think? Otherwise the signature looks a bit strange again.
|
Thanks! |
mrdoob
added a commit
that referenced
this pull request
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup of 00f2725