GLTFExporter: Account for bind matrix. #20804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note, the example I've included in #20803 includes a work-around that simulates this fix by multiplying the bone inverses by the skeleton bind matrix before export: https://glitch.com/edit/#!/transparent-brassy-mercury?path=index.html%3A94%3A37 |
Mugen87
reviewed
Dec 5, 2020
Mugen87
reviewed
Dec 5, 2020
|
Can you please also run |
Yup. Done now. |
Mugen87
reviewed
Dec 5, 2020
Mugen87
approved these changes
Dec 5, 2020
Mugen87
changed the title
takahirox
approved these changes
Dec 6, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: Fixed #20803
Description
Applies
SkinnedMeshbindMatrixto bone inverses when exporting to ensure they retain the correct relation to the mesh.