Fixes SVGLoader arc parsing with zero radius path commands. #20644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
It's also necessary to update |
yomboprime
reviewed
Nov 8, 2020
examples/jsm/loaders/SVGLoader.js
Outdated
|
|
||
| for ( var j = 0, jl = numbers.length; j < jl; j += 7 ) { | ||
| // skip command if start point == end point | ||
| if( numbers[ j + 5 ] == 0 && numbers[ j + 6 ] == 0 ) continue |
Collaborator
There was a problem hiding this comment.
Shouldn't this line be if( numbers[ j + 5 ] == point.x && numbers[ j + 6 ] == point.y ) continue; ?
Contributor
Author
There was a problem hiding this comment.
Νο, the 'a' indicates that the arguments are relative to the current point, so a 0 means no displacement
yomboprime
reviewed
Nov 8, 2020
yomboprime
requested changes
Nov 8, 2020
Collaborator
yomboprime
left a comment
yomboprime
left a comment
There was a problem hiding this comment.
I found three things to be improved.
Collaborator
|
Oops, I messed a little bit the review, but the three things are there. |
gregzanch
commented
Nov 8, 2020
examples/js/loaders/SVGLoader.js
Outdated
Comment on lines
669
to
674
| if( rx == 0 || ry == 0 ) { | ||
| // draw a line if either of the radii == 0 | ||
| path.lineTo( end.x, end.y ); | ||
| return; | ||
| } | ||
|
|
gregzanch
commented
Nov 8, 2020
examples/js/loaders/SVGLoader.js
Outdated
Comment on lines
389
to
391
|
|
||
| // skip command if start point == end point | ||
| if( numbers[ j + 5 ] == point.x && numbers[ j + 6 ] == point.y ) continue; |
yomboprime
approved these changes
Nov 8, 2020
Owner
|
Minor thing: Can change the |
mrdoob
changed the title
Contributor
Author
Just committed the changes! |
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #20641
Description
If an SVG path has an arc command (A/a) with zero radius the path data gets thrown off. Adding a check in the path parser for zero radius fixes this:
Also, to avoid unnecessary computation, a check for useless arc command was added: