WebGLRenderer: Set style.display to block in constructor. #20616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Since I always set this style manually, I'm happy if the engine does it by default 👍 . Maybe also include a default for the |
Owner
Author
Yep! I was going to do the
Yep! |
Owner
Author
|
Actually... After doing some research, I don't think setting I think this is the real issue: three.js/examples/jsm/controls/OrbitControls.js Lines 1186 to 1192 in 4e17099 |
Owner
Author
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Even if
<canvas>setsstyle.displaytoinlineby default, setting it toblockis more suitable for the common usage of the library and frees the developer of having to understand these CSS details.