TS: Added additional type information toArray( ) to support valid usage. #20614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oArray() methods. This allows code involving the spread operator for function parameters (which works as expected) to compile in TypeScript.
mrdoob
reviewed
Nov 3, 2020
donmccurdy
reviewed
Nov 3, 2020
donmccurdy
reviewed
Nov 3, 2020
donmccurdy
approved these changes
Nov 13, 2020
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional type information to Vector and Matrix toArray() methods. This allows code involving the spread operator for function parameters (which works as expected) to compile in TypeScript.
Related issues:
Fixed #19303.
Description
This is the solution - defining tuples for brevity - was proposed by others and well recieved in my original bug report, so I thought I should write these definintions.