GLTFExporter: Clean up. #20470
Merged
GLTFExporter: Clean up. #20470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linbingquan
force-pushed
the
dev-gltf-exporter
branch
from
9791eda to
06a73a0
Compare
Mugen87
reviewed
Oct 7, 2020
Mugen87
approved these changes
Oct 7, 2020
mrdoob
reviewed
Oct 8, 2020
| } | ||
|
|
||
| if ( ! equalArray( object.matrix.elements, [ 1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1 ] ) ) { | ||
| if ( ! isIdentityMatrix( object.matrix ) ) { |
There was a problem hiding this comment.
Sorry, one last change.
if ( isIdentityMatrix( object.matrix ) === false ) {
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure this PR will be better. Please to review the code.