Skip to content

Docs: Update Creating-a-scene.html #20468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 8, 2020
Merged

Docs: Update Creating-a-scene.html #20468

merged 3 commits into from
Oct 8, 2020

Conversation

@montoyamoraga
Copy link
Contributor

change "var" to "let"

@montoyamoraga
Update Creating-a-scene.html
137890c 
change "var" to "let"
geektcp
geektcp reviewed Oct 7, 2020
View reviewed changes
Copy link

@geektcp geektcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Mugen87
Mugen87 reviewed Oct 7, 2020
View reviewed changes
@mrdoob mrdoob added this to the r122 milestone Oct 7, 2020
@montoyamoraga
Update Creating-a-scene.html
8c9d270 
i had changed "var" to "let", changed again to "const"
@montoyamoraga montoyamoraga requested a review from mrdoob October 7, 2020 19:43
@montoyamoraga
Update Creating-a-scene.html
3365344 
change remaining "var" to "const"
@montoyamoraga montoyamoraga requested a review from Mugen87 October 8, 2020 13:49
@mrdoob mrdoob changed the title Update Creating-a-scene.html Docs: Update Creating-a-scene.html Oct 8, 2020
@mrdoob mrdoob merged commit d483a42 into mrdoob:dev Oct 8, 2020
@mrdoob
Copy link
Owner

mrdoob commented Oct 8, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

@mrdoob mrdoob Awaiting requested review from mrdoob

+1 more reviewer

@geektcp geektcp geektcp left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r122

Development

Successfully merging this pull request may close these issues.

4 participants

@montoyamoraga @mrdoob @geektcp @Mugen87