TS: Export TextGeometryParameters #20467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrdoob#20437 is helpful in adding missing exports, but it removed exporting some helpful interfaces like `TextGeometryParamters`. It's a much better experience to be able to do: ``` import { Geometry, Material, MeshBasicMaterial, TextGeometryParameters } from 'three'; ``` rather than: ``` import { Geometry, Material, MeshBasicMaterial } from 'three'; import { TextGeometryParameters } from 'three/src/geometries/TextGeometry'; ```
Mugen87
requested changes
Oct 7, 2020
|
@Mugen87 Thanks for noticing. Any reason not to make the ESLint config have those rules be errors instead of warnings so that the CI will fail? |
@mrdoob has a preference for less configs last time I checked. From your knowledge, can you turn the package.json eslint rules from warnings to errors? |
Mugen87
approved these changes
Oct 8, 2020
|
@DefinitelyMaybe Yeah, just change the 1's to 2's. Should I make a PR? |
|
Give it a go. My brains trying to think about un-intended consequences (like what I came up against when I added the |
Methuselah96
added a commit
to Methuselah96/three.js
that referenced
this pull request
Oct 8, 2020
This will `@typescript-eslint/no-unused-vars` an error instead of a warning. It's helpful for the rule to error so that the build will fail so that you don't have to check the logs to see if there was a warning. See mrdoob#20467 for context.
mrdoob
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#20437 is helpful in adding missing exports, but it removed exporting some helpful interfaces like
TextGeometryParamters. It's a much better experience to be able to do:rather than: