Skip to content

Examples: Remove ExplodeModifier. #20458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2020
Merged

Examples: Remove ExplodeModifier. #20458

merged 1 commit into from
Oct 5, 2020

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Oct 5, 2020 •
edited
Loading

ExplodeModifier is only relevant for Geometry since you can achieve the same effect with BufferGeometry by calling toNonIndexed().

Besides, converting an instance of Geometry to BufferGeometry and back via fromGeometry() and fromBufferGeometry() also makes all faces use unique vertices. So I don't think a separate modifier is necessary.

BTW: ExplodeModifier is not used in the official examples.

@mrdoob
Copy link
Owner

mrdoob commented Oct 5, 2020

Sounds good to me 👌

@mrdoob mrdoob added this to the r122 milestone Oct 5, 2020
@mrdoob mrdoob merged commit 17c81b2 into mrdoob:dev Oct 5, 2020
@mrdoob
Copy link
Owner

mrdoob commented Oct 5, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r122

Development

Successfully merging this pull request may close these issues.

2 participants

@Mugen87 @mrdoob