TS: fix CompressedTextureLoader.d.ts

[linbingquan]

related: #20370

[Mugen87]

It seems you can now delete the load() definition of KTX2Loader.

three.js/examples/jsm/loaders/KTX2Loader.d.ts

Lines 15 to 20 in 538533d

	load(
	url: string,
	onLoad: ( texture: CompressedTexture ) => void,
	onProgress?: ( event: ProgressEvent ) => void,
	onError?: ( event: ErrorEvent ) => void
	): CompressedTexture;

[linbingquan]

I am confused, I see the function is return CompressedTexture in L154.

three.js/examples/jsm/loaders/KTX2Loader.js

Lines 124 to 156 in 538533d

	load( url, onLoad, onProgress, onError ) {
	var scope = this;
	var texture = new CompressedTexture();
	var bufferPending = new Promise( function ( resolve, reject ) {
	new FileLoader( scope.manager )
	.setPath( scope.path )
	.setResponseType( 'arraybuffer' )
	.load( url, resolve, onProgress, reject );
	} );
	this.initModule();
	Promise.all( [ bufferPending, this.basisModulePending ] ).then( function ( [ buffer ] ) {
	scope.parse( buffer, function ( _texture ) {
	texture.copy( _texture );
	texture.needsUpdate = true;
	if ( onLoad ) onLoad( texture );
	}, onError );
	} );
	return texture;
	}

[Mugen87]

Why is this confusing for you^^?

[linbingquan]

Why is this confusing for you^^?

Excuse me, This PR changed is right now?

and you want me to commit this change like it.

diff --git a/examples/jsm/loaders/KTX2Loader.d.ts b/examples/jsm/loaders/KTX2Loader.d.ts
index 1f1d25867..4a0c84ba7 100644
--- a/examples/jsm/loaders/KTX2Loader.d.ts
+++ b/examples/jsm/loaders/KTX2Loader.d.ts
@@ -17,7 +17,7 @@ export class KTX2Loader extends CompressedTextureLoader {
 		onLoad: ( texture: CompressedTexture ) => void,
 		onProgress?: ( event: ProgressEvent ) => void,
 		onError?: ( event: ErrorEvent ) => void
-	): CompressedTexture;
+	): void;
 
 	parse(
 		buffer: ArrayBuffer,

[Mugen87]

No, you can delete the entire method definition. Because it's identical to its upper class.

[linbingquan]

No, you can delete the entire method definition. Because it's identical to its upper class.

Thanks for your reply.

[mrdoob]

Thanks!