Skip to content

Points: Add InterleavedBufferAttribute support to raycast. #20369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 18, 2020
Merged

Points: Add InterleavedBufferAttribute support to raycast. #20369

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e5c153
Update Points.js
manthrax Sep 17, 2020
bb621fc
Change vertex position fetch to use fromBufferAttribute instead of in…
manthrax Sep 17, 2020
190fa8f
Use attribute.count instead of computing it from stride.
manthrax Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/objects/Points.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ Points.prototype = Object.assign( Object.create( Object3D.prototype ), {
const index = geometry.index;
const attributes = geometry.attributes;
const positions = attributes.position.array;
const stride = attributes.position.isInterleavedBufferAttribute ? attributes.position.data.stride : 3;
const offset = attributes.position.isInterleavedBufferAttribute ? attributes.position.offset : 0;

if ( index !== null ) {

Expand All @@ -79,17 +81,17 @@ Points.prototype = Object.assign( Object.create( Object3D.prototype ), {

const a = indices[ i ];

_position.fromArray( positions, a * 3 );
_position.fromArray( positions, a * stride + offset );

testPoint( _position, a, localThresholdSq, matrixWorld, raycaster, intersects, this );

}

} else {

for ( let i = 0, l = positions.length / 3; i < l; i ++ ) {
for ( let i = 0, l = positions.length / stride; i < l; i ++ ) {

_position.fromArray( positions, i * 3 );
_position.fromArray( positions, i * stride + offset );

testPoint( _position, i, localThresholdSq, matrixWorld, raycaster, intersects, this );

Expand Down