Skip to content

TS: purify Vector2.d.ts #20337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2020
Merged

TS: purify Vector2.d.ts #20337

merged 1 commit into from
Sep 14, 2020

Conversation

@ycw
Copy link
Contributor

@ycw ycw commented Sep 13, 2020

  • manhattanLength(): number; already declared at #L346
  • manhattanDistanceTo( v: Vector2 ): number; already declared at #L382

@ycw
purify Vector2.d.ts
071d34d 
- `manhattanLength(): number;`  already declared at #L346
- `manhattanDistanceTo( v: Vector2 ): number;` already declared at #L382
@Mugen87 Mugen87 changed the base branch from master to dev September 13, 2020 20:59
@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 13, 2020

Again, please always target the dev branch with your PRs.

@mrdoob mrdoob added this to the r121 milestone Sep 14, 2020
@mrdoob mrdoob changed the title purify Vector2.d.ts TS: purify Vector2.d.ts Sep 14, 2020
@mrdoob mrdoob merged commit 7960071 into mrdoob:dev Sep 14, 2020
@mrdoob
Copy link
Owner

mrdoob commented Sep 14, 2020

Thanks!

@ycw ycw deleted the patch-1 branch September 14, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r121

Development

Successfully merging this pull request may close these issues.

3 participants

@ycw @Mugen87 @mrdoob