EXRLoader: RLE support and uncompress refactor. #17904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sweet! RLE is working for me. Looking forward to DWAA/B. Thanks! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the previous pipeline into a format that is inline with OpenEXR uncompressing pipeline, and adds support to RLE compression format. Setting up for a future PR that adds support for DWAA and DWAB compression.
By filling the output array with white color, #17887 exposed an incorrect offset in the decoding algorithm. The first pixel line was being shifted up, this was also fixed.
Float32PixelType - except forPIZ_COMPRESSIONDEV Example
PR Example
You can see the example no longer shows that white line on the bottom of the image, since the indexing is now correctly handled.