Skip to content

LOD: Make methods more robust. #17894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 11, 2019
Merged

LOD: Make methods more robust. #17894

merged 4 commits into from
Nov 11, 2019

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Nov 8, 2019

Fixed #17812.

Started with adding a few unit tests to verify the logic.

@Mugen87 Mugen87 added this to the r111 milestone Nov 11, 2019
@Mugen87 Mugen87 merged commit 9f7bc7e into mrdoob:dev Nov 11, 2019
@Mugen87
Copy link
Collaborator Author

Mugen87 commented Nov 11, 2019

Updated builds: a8b0cd4

@mrdoob
Copy link
Owner

mrdoob commented Nov 11, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r111

Development

Successfully merging this pull request may close these issues.

Exception if LOD has no levels defined

2 participants

@Mugen87 @mrdoob