updated TS and docs for shadows #17785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
reviewed
Oct 22, 2019
Mugen87
reviewed
Oct 22, 2019
Collaborator
|
This is really nice clean up! Made a few tests on my local computer and everything works fine. |
Mugen87
approved these changes
Oct 23, 2019
Collaborator
|
Updated builds: 04e23e0 |
Owner
|
Thanks! |
Owner
|
FYI @supereggbert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In using Three's shadows in
<model-viewer>, I found some issues with the TS signature of updateMatrices, which I've resolved here. I also updated the docs to represent that it's really best to leave radius at 1 when using PCFSoftShadowMap, as that completely avoids banding and actually does a pretty nice job when the resolution is reduced (I'm liking 64x64 personally, assuming the shadowMap roughly fills the viewport).