Skip to content

Conversation

@WestLangley
Copy link
Collaborator

DataTexture.generateMipmaps defaults to false. Also, a data texture is not necessarily a POT.

Setting minFilter to LinearFilter is consistent with the other settings.

@WestLangley WestLangley added this to the r110 milestone Oct 20, 2019
Copy link
Collaborator

@Mugen87 Mugen87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes definitely sense.

@Mugen87 Mugen87 merged commit 6907a31 into mrdoob:dev Oct 21, 2019
@Mugen87
Copy link
Collaborator

Mugen87 commented Oct 21, 2019

Update builds: 06b449b

Do we need to add a migration note since the minFilter value of parsed EXR textures and raw data textures has changed?

@WestLangley
Copy link
Collaborator Author

Do we need to add a migration note since the minFilter value of parsed EXR textures and raw data textures has changed?

For DataTextureLoader, yes; for EXRLoader, no.

I have EXRLoader changes coming...

@WestLangley WestLangley deleted the dev_data_texture_loader branch October 22, 2019 01:56
@Mugen87
Copy link
Collaborator

Mugen87 commented Oct 22, 2019

For DataTextureLoader, yes;

Done.

@mrdoob
Copy link
Owner

mrdoob commented Oct 23, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants