Skip to content

Conversation

@yomboprime
Copy link
Collaborator

In Firefox the strokeWidth style property parsed by SVGLoader is being added the string "px" at the end, which results in NaN values inserted in the stroke geometry.

This fixes #17647

To be corrected when SVG units are implemented in #17630

@Mugen87 Mugen87 added this to the r110 milestone Oct 5, 2019
@Mugen87
Copy link
Collaborator

Mugen87 commented Oct 7, 2019

I can confirm strokes are rendered correctly now in FF.

@mrdoob mrdoob merged commit c534d73 into mrdoob:dev Oct 7, 2019
@mrdoob
Copy link
Owner

mrdoob commented Oct 7, 2019

Thanks!

@Mugen87
Copy link
Collaborator

Mugen87 commented Oct 12, 2019

@yomboprime You've updated only the jsm version but not the js file. Fixed this with c2cf0d9. Otherwise node utils/modularize.js would undo your PR.

@yomboprime
Copy link
Collaborator Author

@yomboprime You've updated only the jsm version but not the js file. Fixed this with c2cf0d9. Otherwise node utils/modularize.js would undo your PR.

Thanks, I forgot the other version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SVGLoader strokes don't render in Firefox

3 participants