FileLoader: Fix error response bodies being cached as results #17636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rdoob#17635. Until now, the response body was saved to the cache, no matter what the HTTP status code was. So a request that returned e.g. HTTP 404 with response body "No such file" and `onError` being called would, if run a second time, be found in the cache with "No such file" as the result, and `onLoad("No such file")` would be called, which is nonsensical. One common failure was that texture loaders would thus interpret plain error strings as textures to decode, and failed.
5 tasks
Contributor
Author
|
Please test this thoroughly, as I have only written this fix, not tested it. It's most likely right, but better safe than sorry. |
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17635.
Commit message contains a summary.