Skip to content

Examples: Clean up. #17517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Examples: Clean up. #17517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/js/exporters/GLTFExporter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,7 +901,7 @@ THREE.GLTFExporter.prototype = {

}

if ( material.isShaderMaterial && !material.isGLTFSpecularGlossinessMaterial ) {
if ( material.isShaderMaterial && ! material.isGLTFSpecularGlossinessMaterial ) {

console.warn( 'GLTFExporter: THREE.ShaderMaterial not supported.' );
return null;
Expand Down
2 changes: 1 addition & 1 deletion examples/js/loaders/DRACOLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@ THREE.DRACOLoader.DRACOWorker = function () {

attributeID = decoder.GetAttributeId( dracoGeometry, draco[ attributeIDs[ attributeName ] ] );

if ( attributeID === -1 ) continue;
if ( attributeID === - 1 ) continue;

attribute = decoder.GetAttribute( dracoGeometry, attributeID );

Expand Down
2 changes: 1 addition & 1 deletion examples/js/misc/CarControls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ THREE.CarControls = ( function ( ) {
frontLeftWheelRoot.rotation[ this.wheelTurnAxis ] = wheelOrientation;
frontRightWheelRoot.rotation[ this.wheelTurnAxis ] = wheelOrientation;

steeringWheel.rotation[ this.steeringWheelTurnAxis ] = -wheelOrientation * 6;
steeringWheel.rotation[ this.steeringWheelTurnAxis ] = - wheelOrientation * 6;

},

Expand Down
16 changes: 8 additions & 8 deletions examples/js/vr/HelioWebXRPolyfill.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ if ( /(Helio)/g.test( navigator.userAgent ) && "xr" in navigator ) {

console.log( "Helio WebXR Polyfill (Lumin 0.97.0)" );

const isHelio96 = navigator.userAgent.includes("Chrome/73");
const isHelio96 = navigator.userAgent.includes( "Chrome/73" );

// WebXRManager - XR.supportSession() Polyfill - WebVR.js line 147

Expand All @@ -32,9 +32,9 @@ if ( /(Helio)/g.test( navigator.userAgent ) && "xr" in navigator ) {

return new Promise( function ( resolve, reject ) {

const sessionType = (isHelio96 ? {
const sessionType = ( isHelio96 ? {
mode: 'immersive-ar' // Force using immersive-ar
} : 'immersive-ar');
} : 'immersive-ar' );

tempRequestSession( sessionType )
.then( function ( session ) {
Expand Down Expand Up @@ -74,11 +74,11 @@ if ( /(Helio)/g.test( navigator.userAgent ) && "xr" in navigator ) {

// WebXRManager - xrFrame.getPose() Polyfill - line 259

const tempGetPose = (isHelio96 ? null : frame.getPose.bind( frame ));
const tempGetPose = ( isHelio96 ? null : frame.getPose.bind( frame ) );

frame.getPose = function ( targetRaySpace, referenceSpace ) {

if (isHelio96) {
if ( isHelio96 ) {

const inputPose = frame.getInputPose(
targetRaySpace,
Expand All @@ -93,7 +93,7 @@ if ( /(Helio)/g.test( navigator.userAgent ) && "xr" in navigator ) {

} else {

return tempGetPose(targetRaySpace.gripSpace, referenceSpace);
return tempGetPose( targetRaySpace.gripSpace, referenceSpace );

}

Expand All @@ -113,7 +113,7 @@ if ( /(Helio)/g.test( navigator.userAgent ) && "xr" in navigator ) {

const res = tempGetInputSources();

res.forEach( function (xrInputSource ) {
res.forEach( function ( xrInputSource ) {

Object.defineProperty( xrInputSource, "targetRaySpace", {
get: function () {
Expand Down Expand Up @@ -141,7 +141,7 @@ if ( /(Helio)/g.test( navigator.userAgent ) && "xr" in navigator ) {

// WebXRManager - xrSession.updateRenderState() Polyfill Line 129

if (isHelio96) {
if ( isHelio96 ) {

session.updateRenderState = function ( { baseLayer } ) {

Expand Down
2 changes: 1 addition & 1 deletion examples/jsm/exporters/GLTFExporter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -925,7 +925,7 @@ GLTFExporter.prototype = {

}

if ( material.isShaderMaterial && !material.isGLTFSpecularGlossinessMaterial ) {
if ( material.isShaderMaterial && ! material.isGLTFSpecularGlossinessMaterial ) {

console.warn( 'GLTFExporter: THREE.ShaderMaterial not supported.' );
return null;
Expand Down
2 changes: 1 addition & 1 deletion examples/jsm/loaders/DRACOLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ DRACOLoader.DRACOWorker = function () {

attributeID = decoder.GetAttributeId( dracoGeometry, draco[ attributeIDs[ attributeName ] ] );

if ( attributeID === -1 ) continue;
if ( attributeID === - 1 ) continue;

attribute = decoder.GetAttribute( dracoGeometry, attributeID );

Expand Down
2 changes: 1 addition & 1 deletion examples/jsm/misc/CarControls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ var CarControls = ( function ( ) {
frontLeftWheelRoot.rotation[ this.wheelTurnAxis ] = wheelOrientation;
frontRightWheelRoot.rotation[ this.wheelTurnAxis ] = wheelOrientation;

steeringWheel.rotation[ this.steeringWheelTurnAxis ] = -wheelOrientation * 6;
steeringWheel.rotation[ this.steeringWheelTurnAxis ] = - wheelOrientation * 6;

},

Expand Down