-
-
Notifications
You must be signed in to change notification settings - Fork 36.1k
Editor: Initial implementation of TabbedPanel element #17465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Any chance you could add a screenshot of how does this look like? |
|
EDIT here is the link to sidebar So it looks the same its just that the code is different i will push the changes on sidebar update the PR |
|
Oh I see.
Can you make these changes as part of this PR too? |
|
I will make the changes on the Properties panel as well and update it |
|
done you can check it |
|
Looking good! |
editor/js/libs/ui.js
Outdated
|
|
||
| } | ||
|
|
||
| UI.TabbedPanel.prototype.addPanel = function ( id, label, items ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think UI.TabbedPanel.prototype.addTab would be a better name here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I initiallt thought of that name, but now i dont remember why i changed it :(
|
Thanks got changing the name. I think you forgot to update all the calls. |
|
OOPS |
|
Thanks! |
As per the discussion in PR #17443 will be implementing a few things for the editor. this is a the first of many PR's.
This PR adds a tabbed panel in the UI.
I have sort of just moved the logic from the Sidebar.js to a new UI element and added few more methods.
Next I will be replacing the current tabbed panels with this implementation.