Skip to content

Conversation

@sdinesh86
Copy link
Contributor

As per the discussion in PR #17443 will be implementing a few things for the editor. this is a the first of many PR's.

This PR adds a tabbed panel in the UI.
I have sort of just moved the logic from the Sidebar.js to a new UI element and added few more methods.

Next I will be replacing the current tabbed panels with this implementation.

@mrdoob
Copy link
Owner

mrdoob commented Sep 11, 2019

Any chance you could add a screenshot of how does this look like?

@sdinesh86
Copy link
Contributor Author

sdinesh86 commented Sep 11, 2019

EDIT here is the link to sidebar
https://raw.githack.com/sdinesh86/three.js/editor-ui-additions/editor/index.html

So it looks the same its just that the code is different i will push the changes on sidebar update the PR

@mrdoob
Copy link
Owner

mrdoob commented Sep 11, 2019

Oh I see.

Next I will be replacing the current tabbed panels with this implementation.

Can you make these changes as part of this PR too?

@sdinesh86
Copy link
Contributor Author

I will make the changes on the Properties panel as well and update it

@sdinesh86
Copy link
Contributor Author

done you can check it

@mrdoob
Copy link
Owner

mrdoob commented Sep 11, 2019

Looking good!


}

UI.TabbedPanel.prototype.addPanel = function ( id, label, items ) {
Copy link
Owner

@mrdoob mrdoob Sep 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think UI.TabbedPanel.prototype.addTab would be a better name here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initiallt thought of that name, but now i dont remember why i changed it :(

@mrdoob mrdoob added this to the r109 milestone Sep 11, 2019
@mrdoob
Copy link
Owner

mrdoob commented Sep 12, 2019

Thanks got changing the name. I think you forgot to update all the calls.

@sdinesh86
Copy link
Contributor Author

OOPS

@mrdoob mrdoob merged commit 45a909f into mrdoob:dev Sep 13, 2019
@mrdoob
Copy link
Owner

mrdoob commented Sep 13, 2019

Thanks!

@sdinesh86 sdinesh86 deleted the editor-ui-additions branch September 22, 2019 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants