Fix toggling receiveShadow without changing material #17413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the case where there are two objects with the same material in the scene and one has receiveShadow=true and the other has receiveShadow=false. This also prevents possible extra shader compiles when the same material is reused with receiveShadow enabled or disabled in the same scene.
|
Beautiful!
Agreed. I'll delete the example. |
|
Thanks! |
mrdoob
reviewed
Sep 3, 2019
|
|
||
| if ( refreshMaterial || materialProperties.receiveShadow !== object.receiveShadow ) { | ||
|
|
||
| materialProperties.receiveShadow = object.receiveShadow; |
|
Hmm... I only see this locally, but seems to me that the cloth is self-shadowing? 🤔
Compared to
|
|
Ah yes, still needed to fix the shadowmask code that's used by MeshLambertMaterial. Here's a PR with the remaining fix: #17423 |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the case where there are two objects with the same material in the scene and one has receiveShadow=true and the other has receiveShadow=false.
This also prevents possible extra shader compiles when the same material is reused with receiveShadow enabled or disabled in the same scene.