Skip to content

Conversation

@gkjohnson
Copy link
Collaborator

See #17384 and #17384 (comment)

I'm not sure if people feel it's important to include an inline comment about the need for gl_FragDepth like there used to be but at least the docs should note it.

@mrdoob
Copy link
Owner

mrdoob commented Sep 3, 2019

Hmm... The note is a bit too mysterious.
Would it be hard to explain what these certain rendering optimizations are?

@gkjohnson
Copy link
Collaborator Author

Would it be hard to explain what these certain rendering optimizations are?

Nope! How does this sound:

Note that this setting uses gl_FragDepth if available which disables the Early Fragment Test rendering optimization and can cause a decrease in performance.

@mrdoob
Copy link
Owner

mrdoob commented Sep 3, 2019

Much better! 😀

@gkjohnson
Copy link
Collaborator Author

Updated!

@mrdoob mrdoob changed the title Update logarithmicDepthBuffer docs to note performance caveat Docs: Update logarithmicDepthBuffer with performance caveat Sep 16, 2019
@mrdoob mrdoob added this to the r109 milestone Sep 16, 2019
@mrdoob mrdoob merged commit 81e067e into mrdoob:dev Sep 16, 2019
@mrdoob
Copy link
Owner

mrdoob commented Sep 16, 2019

Thanks!

@gkjohnson gkjohnson deleted the patch-3 branch September 19, 2019 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants