Skip to content

Shaders: Added precisionSafeLength() #17323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Shaders: Added precisionSafeLength() #17323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/renderers/shaders/ShaderChunk/common.glsl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,16 @@ highp float rand( const in vec2 uv ) {
return fract(sin(sn) * c);
}

#ifdef HIGH_PRECISION
float precisionSafeLength( vec3 v ) { return length( v ); }
#else
float max3( vec3 v ) { return max( max( v.x, v.y ), v.z ); }
float precisionSafeLength( vec3 v ) {
float maxComponent = max3( abs( v ) );
return length( v / maxComponent ) * maxComponent;
}
#endif

struct IncidentLight {
vec3 color;
vec3 direction;
Expand Down
4 changes: 4 additions & 0 deletions src/renderers/webgl/WebGLProgram.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,8 @@ function WebGLProgram( renderer, extensions, code, material, shader, parameters,
'precision ' + parameters.precision + ' float;',
'precision ' + parameters.precision + ' int;',

( parameters.precision === 'highp' ) ? '#define HIGH_PRECISION' : '',

'#define SHADER_NAME ' + shader.name,

customDefines,
Expand Down Expand Up @@ -488,6 +490,8 @@ function WebGLProgram( renderer, extensions, code, material, shader, parameters,
'precision ' + parameters.precision + ' float;',
'precision ' + parameters.precision + ' int;',

( parameters.precision === 'highp' ) ? '#define HIGH_PRECISION' : '',

'#define SHADER_NAME ' + shader.name,

customDefines,
Expand Down