Skip to content

Conversation

@elitecool
Copy link

when the transformcontrols bind to the orthographic camera, the eye direction is also the subtraction of camera position and object world position;

…irection is also the subtraction of

camera position and object world position;
@arodic
Copy link
Contributor

arodic commented Aug 23, 2019

Honestly, I don't remember why there was a special case for PerspectiveCamera here. Your change appears to work fine. However, notice that this makes the whole if statement redundant since both branches are the same. Perhaps we should remove the whole if statement and replace it with

eye.copy( cameraPosition ).sub( worldPosition ).normalize();

@mrdoob
Copy link
Owner

mrdoob commented Aug 23, 2019

I'll merge and clean up afterwards.

@mrdoob mrdoob added this to the r108 milestone Aug 23, 2019
@mrdoob mrdoob merged commit 87b10b5 into mrdoob:dev Aug 23, 2019
@mrdoob
Copy link
Owner

mrdoob commented Aug 23, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants