Skip to content

Add missing property to BufferGeometry.d.ts #17205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 8, 2019
Merged

Add missing property to BufferGeometry.d.ts #17205

merged 3 commits into from
Aug 8, 2019

Conversation

@samalexander
Copy link
Contributor

@samalexander samalexander commented Aug 8, 2019

Property isBufferGeometry is missing from the BufferGeometry typescript definitions.

@Mugen87
Copy link
Collaborator

Mugen87 commented Aug 8, 2019

It seems isGeometry is also missing in Geometry.d.ts.

While you're at it, do you mind adding the property? 😇

@Mugen87 Mugen87 added this to the r108 milestone Aug 8, 2019
@Mugen87 Mugen87 merged commit 72ac6e0 into mrdoob:dev Aug 8, 2019
@mrdoob
Copy link
Owner

mrdoob commented Aug 8, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r108

Development

Successfully merging this pull request may close these issues.

3 participants

@samalexander @Mugen87 @mrdoob