Skip to content

WebXR: Fix Reflector and Refractor. #17196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2019
Merged

WebXR: Fix Reflector and Refractor. #17196

merged 1 commit into from
Aug 7, 2019
+16 −8

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Aug 7, 2019

Fixed #17170

@fernandojsg
Copy link
Collaborator

fernandojsg commented Aug 7, 2019

@Mugen87 nice catch! sorry for that 👼 I'll check later on my quest and go and I'll let you! thanks!

fernandojsg
fernandojsg approved these changes Aug 7, 2019
View reviewed changes
Copy link
Collaborator

@fernandojsg fernandojsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the Quest and Go and works as expected 👍

@Mugen87 Mugen87 merged commit 9c5c76a into mrdoob:dev Aug 7, 2019
@Mugen87 Mugen87 added this to the r108 milestone Aug 7, 2019
@mrdoob
Copy link
Owner

mrdoob commented Aug 7, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fernandojsg fernandojsg fernandojsg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r108

Development

Successfully merging this pull request may close these issues.

Ocean example breaks in WebVR mode

3 participants

@Mugen87 @fernandojsg @mrdoob