Skip to content

Conversation

@sunag
Copy link
Collaborator

@sunag sunag commented Aug 7, 2019

#17163 (comment)

@WestLangley This is the experiment, note that for irradiance the default value is 1 in bias, for me in irradiance the result is good for both. Without LOD if compared with BASIC is bad in radiance because it needs intermediate values (0-1).

https://rawgit.com/sunag/three.js/dev-nodes-irradiance/examples/webgl_materials_nodes.html?e=bias

@sunag
Copy link
Collaborator Author

sunag commented Aug 7, 2019

In my conclusion, I not see reasons for not use this feature.
#17163 (comment)

@sunag
Copy link
Collaborator Author

sunag commented Aug 7, 2019

only for test and obtain a clean result I put a PREM in PhongNodeMaterial 😅

@sunag
Copy link
Collaborator Author

sunag commented Aug 7, 2019

The blur based on the intermediate curve of bias seems different for both. Only to ensure I will to do more tests related to PBM roughness.

@sunag
Copy link
Collaborator Author

sunag commented Aug 7, 2019

The blur based on the intermediate curve of bias seems different for both. Only to ensure I will to do more tests related to PBM roughness.

This not affect this test.

@mrdoob mrdoob added this to the r108 milestone Aug 7, 2019
@mrdoob mrdoob merged commit 1bda529 into mrdoob:dev Aug 8, 2019
@mrdoob
Copy link
Owner

mrdoob commented Aug 8, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants