Math: Remove closures part III. #17159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrdoob
reviewed
Aug 2, 2019
Collaborator
Author
|
Okay, all closures are now removed from |
mrdoob
reviewed
Aug 5, 2019
| getBarycoord: function ( point, a, b, c, target ) { | ||
|
|
||
| return function getBarycoord( point, a, b, c, target ) { | ||
| if ( _v1 === undefined ) { |
Owner
There was a problem hiding this comment.
I understand why this is not checking for _v0, but I think checking for _v2 may be easier to understand.
Owner
There was a problem hiding this comment.
I mean changing the pattern to check for the last item instead of the first item (in this case the second item because of... reasons).
Collaborator
Author
There was a problem hiding this comment.
Okay, makes sense. I'll adapt this pattern for future PRs 👍. Triangle is improved here: #17182
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #17120.
Box3,Math,Matrix4,RayandTriangle.