Skip to content

Conversation

@gkjohnson
Copy link
Collaborator

See #15611 (comment)

This change adds stencil locking to the MaskPass effect code and modifies to stencil state to respect the lock state when enabling / disabling the stencil buffer. In my opinion the setOp and setFunc functions should also respect the locked state but I'll wait for feedback before making that change, too.

Note that this PR requires a new build before the webgl_postprocessing_masking example will work again.

@WestLangley WestLangley added this to the r107 milestone Jul 31, 2019
@WestLangley
Copy link
Collaborator

@mrdoob After testing, I believe this is an acceptable fix for r.107.

@mrdoob mrdoob modified the milestones: r107, r108 Aug 1, 2019
@mrdoob
Copy link
Owner

mrdoob commented Aug 1, 2019

Doesn't seem like this deserves a hotfix for r107. Merging for 108.

@mrdoob mrdoob merged commit 7973543 into mrdoob:dev Aug 1, 2019
@mrdoob
Copy link
Owner

mrdoob commented Aug 1, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants