Suggestion: Expose and document Raycaster.camera #17118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't forget to update the TS file for |
Mugen87
approved these changes
Jul 29, 2019
|
@gkjohnson Can you please resolve the merge conflicts? I'd like to merge this PR in order to see if it helps to avoid such problems: #17142 (comment) |
…er-camera-suggestion # Conflicts: # src/objects/Sprite.js
|
@Mugen87 Just merged and readded the changes! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #17078, #16423
This is just a suggestion for how to more explicitly document and expose the
Raycaster.camerafield and (hopefully) make it feel less like magic when callingRaycaster.setCamera. I feel that treating theRaycasterobject as a kind of context that hold data needed for different types of objects to perform their raycast is a useful pattern.camerais something that can be used when implementing custom raycast functions for objects that scale based on camera distance or billboard in shaders (such as with lines).