Skip to content

Conversation

@munrocket
Copy link
Contributor

No description provided.

Mugen87
Mugen87 previously approved these changes Jul 23, 2019
@Mugen87 Mugen87 dismissed their stale review July 23, 2019 16:23

Changed my mind...

@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 23, 2019

I think it's better to only advocate the ES6 approach and remove the others. Besides, the following line needs a change otherwise user will get a runtime error when copy/paste the code.

https://github.com/mrdoob/three.js/pull/17076/files#diff-b272ae25a77c61d4e305bea9106871afR107

var loader = new THREE.GLTFLoader(); has to be var loader = new GLTFLoader();

@munrocket
Copy link
Contributor Author

munrocket commented Jul 23, 2019

and remove the others

After that we will need to change all documentation. I will add two additional words before example of code to be fully correct.

@munrocket
Copy link
Contributor Author

If you want that we can edit all examples in documentation one by one and add LoadingManager to them also.

@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 23, 2019

Okay, it's fine like that.

@Mugen87 Mugen87 merged commit 8779095 into mrdoob:dev Jul 24, 2019
@Mugen87 Mugen87 added this to the r107 milestone Jul 24, 2019
@mrdoob
Copy link
Owner

mrdoob commented Jul 24, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants