Skip to content

OrbitControls: Normalize rotation speed when damping is used #17059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2019
Merged

OrbitControls: Normalize rotation speed when damping is used #17059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions examples/js/controls/OrbitControls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,17 @@ THREE.OrbitControls = function ( object, domElement ) {

}

spherical.theta += sphericalDelta.theta;
spherical.phi += sphericalDelta.phi;
if ( scope.enableDamping ) {

spherical.theta += sphericalDelta.theta * scope.dampingFactor;
spherical.phi += sphericalDelta.phi * scope.dampingFactor;

} else {

spherical.theta += sphericalDelta.theta;
spherical.phi += sphericalDelta.phi;

}

// restrict theta to be between desired limits
spherical.theta = Math.max( scope.minAzimuthAngle, Math.min( scope.maxAzimuthAngle, spherical.theta ) );
Expand Down
13 changes: 11 additions & 2 deletions examples/jsm/controls/OrbitControls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,17 @@ var OrbitControls = function ( object, domElement ) {

}

spherical.theta += sphericalDelta.theta;
spherical.phi += sphericalDelta.phi;
if ( scope.enableDamping ) {

spherical.theta += sphericalDelta.theta * scope.dampingFactor;
spherical.phi += sphericalDelta.phi * scope.dampingFactor;

} else {

spherical.theta += sphericalDelta.theta;
spherical.phi += sphericalDelta.phi;

}

// restrict theta to be between desired limits
spherical.theta = Math.max( scope.minAzimuthAngle, Math.min( scope.maxAzimuthAngle, spherical.theta ) );
Expand Down