Skip to content

OrbitControls: missing namespace #17007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2019
Merged

OrbitControls: missing namespace #17007

merged 1 commit into from
Jul 11, 2019

Conversation

@sciecode
Copy link
Contributor

@sciecode sciecode commented Jul 11, 2019

#16961 follow-up

missed constant namespace for non-module.

@WestLangley WestLangley added this to the r107 milestone Jul 11, 2019
@WestLangley WestLangley merged commit 63e868a into mrdoob:dev Jul 11, 2019
@WestLangley
Copy link
Collaborator

WestLangley commented Jul 11, 2019

Thanks!

@sciecode sciecode deleted the dev-controls branch July 11, 2019 02:22
@mrdoob
Copy link
Owner

mrdoob commented Jul 11, 2019

Thanks thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r107

Development

Successfully merging this pull request may close these issues.

3 participants

@sciecode @WestLangley @mrdoob