-
-
Notifications
You must be signed in to change notification settings - Fork 36.1k
Added lower-case Mipmap constants #16981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think I would already use the new constants in the code base. Just introducing them in |
|
This is ridiculous. The PR is too small? Let's merge PRs and make progress. |
|
PRs should represent meaningful bundles of work. I don't think it makes sense to just add a few constants to the lib. If you want to make progress, you should already introduce them in the rest of the code base. BTW: #16671 has a similar problem. You have introduced |
|
This PR adds support for the new nomenclature ("Mipmap"), while maintaining backwards-compatibility with the old ("MipMap"). I'll file another PR to use the new nomenclature in the source code, while leaving the examples as-is. If that works, I'll update the examples to use the new nomenclature as a final step. I think we want to maintain backwards-compatibility, so that means supporting both the new and the old nomenclatures. Maybe someone has a suggestion for how the old nomenclature can be deprecated... |
|
Again, I'm against this type of PR style. Remembers me at salami tactics.... |
|
TIL about salami tactics 😁 Doing perfect PRs can be a bit taxing, so I'm okay with solving issues in multiple PRs. |
Maybe we should turn them into getters and log a warning when accessed? |
Hmm... how is that done? 🤔 |
Inspired by #6457 (comment).
It is
_gl.LINEAR_MIPMAP_LINEAR, not_gl.LINEAR_MIP_MAP_LINEAR.The boolean
generateMipmapsuses the correct nomenclature.This PR is a first-step. We can discuss the best way to proceed.