Skip to content

Example webgl2 fixes #16886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 23, 2019
Merged

Example webgl2 fixes #16886

merged 12 commits into from
Jun 23, 2019

Conversation

@aardgoose
Copy link
Contributor

@aardgoose aardgoose commented Jun 22, 2019 •
edited by mrdoob
Loading

Bulk of examples fixed to work with WebGL2 contexts

  • rename uniforms where name conflicts with GLSL texture() function
  • function in shader that is now implemented in GLSL 3.0: tanh(), round()
  • added WebGL2 capability detection in GPUComputationalRenderer + lint fixes

Fixes #16870

@mrdoob mrdoob added this to the r106 milestone Jun 23, 2019
@mrdoob mrdoob merged commit 18e0b9f into mrdoob:dev Jun 23, 2019
@mrdoob
Copy link
Owner

mrdoob commented Jun 23, 2019

Thanks!

@aardgoose aardgoose deleted the example-webgl2-fixes branch June 23, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r106

Development

Successfully merging this pull request may close these issues.

example shaders not compatible with WebGL2

2 participants

@aardgoose @mrdoob