Skip to content

Tests: Clean up #16881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2019
Merged

Tests: Clean up #16881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/unit/src/core/InstancedBufferAttribute.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export default QUnit.module( 'Core', () => {
var instance = new InstancedBufferAttribute( new Float32Array( 10 ), 2 );
assert.ok( instance.meshPerAttribute === 1, "ok" );

var instance = new InstancedBufferAttribute( new Float32Array( 10 ), 2, 123 );
var instance = new InstancedBufferAttribute( new Float32Array( 10 ), 2, false, 123 );
assert.ok( instance.meshPerAttribute === 123, "ok" );

} );
Expand All @@ -31,11 +31,12 @@ export default QUnit.module( 'Core', () => {
QUnit.test( "copy", ( assert ) => {

var array = new Float32Array( [ 1, 2, 3, 7, 8, 9 ] );
var instance = new InstancedBufferAttribute( array, 2, 123 );
var instance = new InstancedBufferAttribute( array, 2, true, 123 );
var copiedInstance = instance.copy( instance );

assert.ok( copiedInstance instanceof InstancedBufferAttribute, "the clone has the correct type" );
assert.ok( copiedInstance.itemSize === 2, "itemSize was copied" );
assert.ok( copiedInstance.normalized === true, "normalized was copied" );
assert.ok( copiedInstance.meshPerAttribute === 123, "meshPerAttribute was copied" );

for ( var i = 0; i < array.length; i ++ ) {
Expand Down
11 changes: 1 addition & 10 deletions test/unit/src/geometries/TextGeometry.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,7 @@ import {

export default QUnit.module( 'Geometries', () => {

QUnit.module( 'TextBufferGeometry', ( hooks ) => {

var geometries = undefined;
hooks.beforeEach( function () {

geometries = [
new TextBufferGeometry()
];

} );
QUnit.module( 'TextBufferGeometry', () => {

// INHERITANCE
QUnit.todo( "Extending", ( assert ) => {
Expand Down
16 changes: 4 additions & 12 deletions test/unit/src/math/Line3.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,27 +81,19 @@ export default QUnit.module( 'Maths', () => {

QUnit.test( "getCenter", ( assert ) => {

var center = new Vector3();

var a = new Line3( zero3.clone(), two3.clone() );
assert.ok( a.getCenter().equals( one3.clone() ), "Passed" );


var a = new Line3( zero3.clone(), two3.clone() );
var b = new Vector3();
assert.ok( a.getCenter( b ).equals( one3.clone() ), "Passed" );

assert.ok( a.getCenter( center ).equals( one3.clone() ), "Passed" );

} );

QUnit.test( "delta", ( assert ) => {

var delta = new Vector3();

var a = new Line3( zero3.clone(), two3.clone() );
assert.ok( a.delta().equals( two3.clone() ), "Passed" );
var a = new Line3( one3.clone(), two3.clone() );
var b = new Vector3();
assert.ok( a.delta( b ).equals( one3.clone() ), "Passed" );

assert.ok( a.delta( delta ).equals( two3.clone() ), "Passed" );

} );

Expand Down