Skip to content

JSM: Use "module" instead of "min" prefix for libs. #16862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2019
Merged

JSM: Use "module" instead of "min" prefix for libs. #16862

merged 1 commit into from
Jun 20, 2019

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jun 20, 2019

To better indicate that these libs are actually modules.

@Mugen87 Mugen87 added this to the r106 milestone Jun 20, 2019
@Mugen87 Mugen87 merged commit 929929b into mrdoob:dev Jun 20, 2019
@Mugen87 Mugen87 mentioned this pull request Jun 20, 2019
Merged
@mrdoob
Copy link
Owner

mrdoob commented Jun 20, 2019

I guess they can also be name.module.min.js?

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jun 21, 2019

I think so 😅

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jun 21, 2019

How about this:

chevrotain.module.min.js
dat.gui.module.js
gunzip.module.min.js
inflate.module.min.js
mmdparser.module.js
stats.module.js

@mrdoob
Copy link
Owner

mrdoob commented Jun 21, 2019

That works 👌

@Mugen87 Mugen87 mentioned this pull request Jun 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r106

Development

Successfully merging this pull request may close these issues.

2 participants

@Mugen87 @mrdoob