Skip to content

Add box2 unittests #16780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 14, 2019
Merged

Add box2 unittests #16780

merged 4 commits into from
Jun 14, 2019

Conversation

@gero3
Copy link
Contributor

@gero3 gero3 commented Jun 13, 2019 •
edited
Loading

This adds the missing unit tests for box2. It fails on 1 unit test:

  • A box with vectors (0,0) and (0,0) is not empty.

PS: I need to read the docs

@gero3 gero3 changed the title add box2 unittests Add box2 unittests Jun 13, 2019
@mrdoob mrdoob added this to the r106 milestone Jun 14, 2019
@mrdoob mrdoob merged commit 38da3e9 into mrdoob:dev Jun 14, 2019
@mrdoob
Copy link
Owner

mrdoob commented Jun 14, 2019

Thanks!

@gero3 gero3 deleted the AddMathUnitTests branch September 11, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r106

Development

Successfully merging this pull request may close these issues.

3 participants

@gero3 @mrdoob @Mugen87