Skip to content

Conversation

@WestLangley
Copy link
Collaborator

Follow-up to #16755.

Migration docs updated separately.

@WestLangley WestLangley added this to the r106 milestone Jun 12, 2019
@WestLangley
Copy link
Collaborator Author

WestLangley commented Jun 12, 2019

Note: the TS files are not consistent in setting return values. For example:

set( x: number, y: number, z: number, w: number ): Quaternion;
clone(): this;
copy( q: Quaternion ): this;
setFromEuler( euler: Euler ): Quaternion;

/ping @Mugen87 @looeee

@mrdoob mrdoob merged commit 1b18a79 into mrdoob:dev Jun 12, 2019
@mrdoob
Copy link
Owner

mrdoob commented Jun 12, 2019

Thanks!

@WestLangley WestLangley deleted the dev_ts branch June 12, 2019 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants